Crud internship

Created by: hihubbIe

unsupported: PDF upload not yet handled for state tracking

src/internships/dao/internships.dao.ts

-import {
-  Injectable,
-  NotFoundException,
-  InternalServerErrorException,
-} from '@nestjs/common';
+import { Injectable, NotFoundException } from '@nestjs/common';
 import { InjectModel } from '@nestjs/mongoose';
 import { Model } from 'mongoose';
+import { CONFLICT } from 'src/shared/HttpError';
+import { STATE_1 } from 'src/shared/InternshipState';
+import { STATUS_NOK } from 'src/shared/InternshipStatus';
 import { CreateInternshipDto } from '../dto/create-internship.dto';
 import { InternshipDto } from '../dto/internship.dto';
-import { TrackingDto } from '../dto/nested-create/tracking.dto';
 import { Internship } from '../schemas/internship.schema';
 
 @Injectable()
 export class InternshipDao {
   constructor(
     @InjectModel(Internship.name)
-    private readonly _groupModel: Model<Internship>,
+    private readonly _internshipModel: Model<Internship>,
   ) {}
 
   find = (): Promise<Internship[]> =>
     new Promise((resolve, reject) => {
-      this._groupModel.find({}, {}, {}, (err, value) => {
+      this._internshipModel.find({}, {}, {}, (err, value) => {
         if (err) reject(err.message);
         if (!value) reject('No values');
         resolve(value);
@@ -28,7 +26,7 @@ export class InternshipDao {
 
   findByStudentId = (studentId: string): Promise<Internship | void> =>
     new Promise((resolve, reject) => {
-      this._groupModel.findOne({ studentId }, {}, {}, (err, value) => {
+      this._internshipModel.findOne({ studentId }, {}, {}, (err, value) => {
         if (err) reject(err.message);
         if (!value) reject(new NotFoundException());
         resolve(value);
@@ -37,29 +35,34 @@ export class InternshipDao {
 
   save = (internship: CreateInternshipDto): Promise<Internship> =>
     new Promise((resolve, reject) => {
-      // do smth
-      const _internship: InternshipDto = {
-        ...internship,
-        tracking: {
-          state: 'state-1',
-          status: 'pending',
+      // Use updateOne with `upsert: true` to only insert when no other document has the same studentId to prevent duplicata
+      const decoratedInternship = this.toInternshipDtoWithTracking(internship);
+      this._internshipModel.updateOne(
+        { studentId: internship.studentId },
+        { $setOnInsert: decoratedInternship },
+        {
+          upsert: true,
+          runValidators: true,
         },
-      };
-      new this._groupModel(_internship).save((err, value) => {
-        if (err) reject(err.message);
-        if (!value) reject(new InternalServerErrorException());
-        resolve(value);
-      });
+        (err, value) => {
+          const { upsertedCount } = value;
+          if (err) reject(err.message);
+          if (upsertedCount === 0) reject(CONFLICT);
+          resolve(decoratedInternship as Internship);
+        },
+      );
     });
 
   findByStudentIdAndUpdate = (
     studentId: string,
-    internship: InternshipDto,
+    internship: CreateInternshipDto,
   ): Promise<Internship | void> =>
     new Promise((resolve, reject) => {
-      this._groupModel.findOneAndReplace(
-        { studentId },
-        internship,
+      // Check if information modification is allowed -> current state is information input by student and updating is allowed
+      const decoratedInternship = this.toInternshipDtoWithTracking(internship);
+      this._internshipModel.findOneAndReplace(
+        { studentId, 'tracking.state': STATE_1, 'tracking.status': STATUS_NOK },
+        decoratedInternship,
         {
           new: true,
           runValidators: true,
@@ -73,9 +76,21 @@ export class InternshipDao {
 
   findByStudentIdAndRemove = (studentId: string): Promise<Internship | void> =>
     new Promise((resolve, reject) => {
-      this._groupModel.findOneAndDelete({ studentId }, {}, (err) => {
+      this._internshipModel.findOneAndDelete({ studentId }, {}, (err) => {
         if (err) reject(err.message);
         resolve();
       });
     });
+
+  toInternshipDtoWithTracking = (
+    createInternshipDto: CreateInternshipDto,
+  ): InternshipDto => {
+    return {
+      ...createInternshipDto,
+      tracking: {
+        state: 'state-1',
+        status: 'nok',
+      },
+    };
+  };
 }