From 7124b2dada6ca64e5828df73d77b1315bcaffd32 Mon Sep 17 00:00:00 2001
From: Thomas Fradet <t.fradet8@gmail.com>
Date: Mon, 27 May 2019 13:53:05 +0200
Subject: [PATCH] useless script removed
---
CHANGELOG.md | 8 ++++++++
career_unit.php | 6 +++---
styles.css | 9 +++++++++
view/view_career_unit.php | 4 ++--
4 files changed, 22 insertions(+), 5 deletions(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 37f6369..98a8209 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -46,5 +46,13 @@ Suppression de la possibilité de plier / déplier les description de parcours e
Amélioration de l'affichage des titres et de la liste des ressources du parcours.
+#### CSS inutile
+
+Nettoyage de CSS inutile.
+
+#### Scripts inutiles
+
+Non inclusion de scripts inutiles dans la page career_unit.php.
+
diff --git a/career_unit.php b/career_unit.php
index ee633e5..9a79b99 100644
--- a/career_unit.php
+++ b/career_unit.php
@@ -21,9 +21,9 @@
$PAGE->set_title(get_string('title_plugin', 'block_career'));
$PAGE->set_heading($OUTPUT->heading($COURSE->fullname, 2, 'headingblock header outline'));
echo $OUTPUT->header();
- $PAGE->requires->js("/blocks/career/js/jquery.min.js");
- $PAGE->requires->js("/blocks/career/js/file.js");
- echo "<link rel=\"stylesheet\" type=\"text/css\" href=\"styles.css\">";
+ // $PAGE->requires->js("/blocks/career/js/jquery.min.js");
+ // $PAGE->requires->js("/blocks/career/js/file.js");
+ // echo "<link rel=\"stylesheet\" type=\"text/css\" href=\"styles.css\">";
require_once('view/view_career_unit.php');
diff --git a/styles.css b/styles.css
index c4b6582..220e7cb 100644
--- a/styles.css
+++ b/styles.css
@@ -14,6 +14,15 @@
padding: 0.6rem 1rem;
}
+.career-descr {
+ padding: .75rem 1.25rem;
+ margin-bottom: 1rem;
+ border: 0 solid transparent;
+ border-color: #f1f3f5;
+ color: #6b6e71;
+ background-color: #f5f6f8;
+}
+
/* Path settings */
.left_course_elements, .right_course_elements {
width: 33%;
diff --git a/view/view_career_unit.php b/view/view_career_unit.php
index f4b9791..581a5c6 100644
--- a/view/view_career_unit.php
+++ b/view/view_career_unit.php
@@ -56,8 +56,8 @@ ksort($sections);
<section class="section">
- <h2 class="display-3"><?=$titre;?></h2>
- <div class="iena-carrer-path-descr wrapper">
+ <h2 class="display-4"><?=$titre;?></h2>
+ <div class="career-descr">
<?php echo $intro; ?>
</div>
<?php foreach ($sections as $section) : ?>
--
GitLab